Skip to content

fix: skip closed issues already fixed before installed version - #51

Merged
harlan-zw merged 1 commit into
mainfrom
fix/skip-pre-release-closed-issues
Mar 24, 2026
Merged

fix: skip closed issues already fixed before installed version#51
harlan-zw merged 1 commit into
mainfrom
fix/skip-pre-release-closed-issues

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Mar 24, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

N/A

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Closed issue fetching previously only set an upper bound (releasedAt + 6 months) with no lower bound, so it pulled in issues that were already resolved before the user's installed version. Now adds closed:>=releasedAt as a lower bound, ensuring only issues closed after the release are included. For recent versions (within 6 months), all post-release closed issues are fetched. For older versions, the existing +6 month upper cap is preserved to bound result size.

Summary by CodeRabbit

  • Bug Fixes
    • Improved filtering of closed issues for a release: excludes issues closed before the release date and constrains results to a six-month window after release when applicable, yielding more accurate and relevant issue lists.

@coderabbitai

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31fbd67e-ef6b-4efa-a048-5c1609c8a4bc

📥 Commits

Reviewing files that changed from the base of the PR and between daebed5 and 46fe89b.

📒 Files selected for processing (1)
  • src/sources/issues.ts
✅ Files skipped from review due to trivial changes (1)
  • src/sources/issues.ts
📝 Walkthrough

Walkthrough

The closed-issue date filtering now adds a lower bound at releasedAt and applies an upper bound at releasedAt + 6 months only if that cap is already in the past; previously only an upper bound was used.

Changes

Cohort / File(s) Summary
Closed Issue Date Filtering
src/sources/issues.ts		 Adjusts GitHub search datePart for closed issues: adds +closed:>=releasedAt lower bound and conditionally appends +closed:<=releasedAt+6 months only when the cap is before now; removes unconditional upper-only behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through dates and set a gate,
From release time onward — now it's straight,
Six-month cap waits if time is late,
Cleaner issues found — a tidy state! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: adding a lower bound to exclude closed issues that existed before the installed version.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/skip-pre-release-closed-issues

Comment @coderabbitai help to get the list of available commands and usage tips.

@harlan-zw harlan-zw changed the title fix(issues): skip closed issues already fixed before installed version fix: skip closed issues already fixed before installed version Mar 24, 2026
@harlan-zw
fix(issues): skip closed issues already fixed before installed version
46fe89b 
Previously, closed issue fetching only set an upper bound (releasedAt + 6mo)
with no lower bound, pulling in issues resolved before the user's version.
Now adds closed:>=releasedAt as a lower bound so only post-release fixes
are included. Keeps the +6mo upper cap for old versions to bound result size.
@harlan-zw
harlan-zw force-pushed the fix/skip-pre-release-closed-issues branch from daebed5 to 46fe89b Compare March 24, 2026 08:25
@harlan-zw
harlan-zw merged commit 89dc01a into main Mar 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@harlan-zw